Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimadeRester: Add ability to request additional response fields #2314

Closed
ml-evs opened this issue Nov 29, 2021 · 0 comments · Fixed by #2315
Closed

OptimadeRester: Add ability to request additional response fields #2314

ml-evs opened this issue Nov 29, 2021 · 0 comments · Fixed by #2315

Comments

@ml-evs
Copy link
Contributor

ml-evs commented Nov 29, 2021

We have just run into an issue (Materials-Consortia/optimade-tutorial-exercises#8) where the pymatgen OPTIMADE tutorial fails to pull custom provider fields since #2244 was merged, as this PR (correctly) enforced the response fields required to create pymatgen structures from OPTIMADE responses, to the exclusion of all other fields.

As a quick fix, I suggest adding a additional_response_fields argument to the public methods of OptimadeRester that are used when constructing the query.

I am happy to knock up a PR if this is desired, but for now we will probably have to remove that section of the pymatgen tutorial.

(paging @mkhorton - the tutorials are now being used for a new workshop, hence the interest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant