-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry sets use wrong Yb pseudo-potential #2968
Comments
I don't really have any concerns. I think whether Yb_2 or Yb_3 depends on what you are calculating. VASP "recommends" Yb_2 as the PSP. See https://www.vasp.at/wiki/index.php/Available_PAW_potentials. This was probably the reason why we used that in the first place. For HT efforts, we have to select one. I am fine with switching to Yb_3 given that most Yb exists in 3+ oxidation state. |
This docs page needs updating. It incorrectly states we use |
The docs page need to be updated for sure. But the docs seem to be based on the old HT framework at MIT. When we did MP, there was a deliberate change in PSP used. Anyway, like I said, no issue with switching to Yb3+. |
@munrojm Change request for docs page submitted on gitbooks. |
@janosh merging now |
I don’t recall, but I believe it. The consequence of changing the MP Input Set is that current data on MP will the be inconsistent with the MP Input Set; since a lot of people generate data intentionally to be compatible with MP, this can cause a lot of downstream problems (even in this case, where the change is sensible and necessary). Around that time we were also talking about reviewing other pseudopotential choices in MP, eg some pseudopotentials we’re not used because of ghost states (perhaps Na? I forget), but these issues were later fixed in the newer 54 pseudopotentials that the MP SCAN Input Set uses. The SCAN Input Set presented an opportunity to cleanly make this change. However this was not pursued, I think more out of conservativeness than anything. All this to say, I’m glad this change was made, but if I could offer a viewpoint to the MP team, it’s that a new data release to replace the Yb data should also be done promptly (although I realise this may not be possible!), as well as a louder mention of this change in the relevant places (eg docs changelog, or a banner on the linked docs page) might be a good idea too, to let people know this change is coming. |
Just an FYI for everyone here that I am moving to re-calculate all the Yb compounds right now. The plan is to stop working on the current MP build to get these done and incorporated. |
Yes this is definitely planned! 👍
This is also planned but the timeline is less firm. |
Lol, simultaneous posts. 😄 I stand corrected. Timeline for updating Yb compounds is very firm. 🚀 |
@mkhorton Any suggestions for this banner on the PSP docs page? |
Looks perfect :) |
Perhaps additional information to add somewhere might simply be some screenshots or descriptions of the two relevant chemical systems to demonstrate the difference. It might help justify the change, rather than "because we say so", as well as point(s)-of-contact for who investigated the issue. I say this as someone who's wished this information was available with previous decisions, but where I was unable to track down additional context. |
Definitely! That's the reason I tried to @-mention all people I know have knowledge of this matter in the original issue above. I made sure all places documenting this change link back to this issue so hopefully people in the future can follow the trail to determine who to contact with questions. What I wrote above is most of the context I have. Of course, others are welcome to add. Another tidbit I learned later is that prompted by A-lab results, @mattmcdermott very recently tried to re-run a bunch of |
@janosh yep, I ran 20ish compounds with the |
Also I meant to send this earlier -- this is not the most rigorous comparison, but here is a look at the Yb-Mo-O phase diagram (GGA/GGA+U) before and after I recomputed the Yb entries with the Big differences -- notably, the very common Yb2O3 moves to be stable after previously being >200 meV/atom above the hull. Also stabilizes two ternary phases and destabilizes YbMoO4 greatly |
I don't know if I am experienced enough for this conversation, but I was able to get YbCl3 relaxation converged using |
Any and all relevant anecdotes are welcome! The more data we have, the better our decisions. |
The docs are incorrect on what pseudo-potential the
EntrySet
s use forYb
. Docs sayYb_3
, actual isYb_2
. Just to list a few:pymatgen/pymatgen/io/vasp/MPRelaxSet.yaml
Line 171 in a7ee5ad
pymatgen/pymatgen/io/vasp/MPSCANRelaxSet.yaml
Line 123 in a7ee5ad
pymatgen/pymatgen/io/vasp/MVLRelax52Set.yaml
Line 177 in a7ee5ad
pymatgen/pymatgen/io/vasp/MPAbsorptionSet.yaml
Line 113 in a7ee5ad
The A-lab revealed that as a result of using
Yb_2
the energy on Yb compounds is off by a lot, resulting in supposedly stable things being unsynthesizable. While an unfortunate mistake, it's also great to see how experiment can help surface simulation errors. (@rekumar) (Although if tales are correct, @arosen93 originally brought this up with @mkhorton in Oct 2021?)Planned solution is to update all input sets to actually use Yb_3. Why not
Yb
so as not to force an oxidation state? ApparentlyYb
has stability issues. Additional context in@shyuep Any concerns on your end? We plan to highlight this change in the pymatgen release notes and in the next MP database release. Any additional venues?
Unfortunately, this comes too late for the large data set Google generated which used the current
MPRelaxSet
andMPSCANRelaxSet
but better fix this now before another large effort gets this wrong.The text was updated successfully, but these errors were encountered: