Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry sets use wrong Yb pseudo-potential #2968

Closed
janosh opened this issue May 2, 2023 · 17 comments · Fixed by #2969
Closed

Entry sets use wrong Yb pseudo-potential #2968

janosh opened this issue May 2, 2023 · 17 comments · Fixed by #2969
Labels
bug linting Linting and quality assurance vasp Vienna Ab initio Simulation Package

Comments

@janosh
Copy link
Member

janosh commented May 2, 2023

The docs are incorrect on what pseudo-potential the EntrySets use for Yb. Docs say Yb_3, actual is Yb_2. Just to list a few:

The A-lab revealed that as a result of using Yb_2 the energy on Yb compounds is off by a lot, resulting in supposedly stable things being unsynthesizable. While an unfortunate mistake, it's also great to see how experiment can help surface simulation errors. (@rekumar) (Although if tales are correct, @arosen93 originally brought this up with @mkhorton in Oct 2021?)

Planned solution is to update all input sets to actually use Yb_3. Why not Yb so as not to force an oxidation state? Apparently Yb has stability issues. Additional context in

@shyuep Any concerns on your end? We plan to highlight this change in the pymatgen release notes and in the next MP database release. Any additional venues?

Unfortunately, this comes too late for the large data set Google generated which used the current MPRelaxSet and MPSCANRelaxSet but better fix this now before another large effort gets this wrong.

@janosh janosh added bug linting Linting and quality assurance vasp Vienna Ab initio Simulation Package labels May 2, 2023
@janosh janosh changed the title Entry sets use wrong Yb psuedo-potential Entry sets use wrong Yb pseudo-potential May 2, 2023
@shyuep
Copy link
Member

shyuep commented May 2, 2023

I don't really have any concerns. I think whether Yb_2 or Yb_3 depends on what you are calculating. VASP "recommends" Yb_2 as the PSP. See https://www.vasp.at/wiki/index.php/Available_PAW_potentials. This was probably the reason why we used that in the first place. For HT efforts, we have to select one. I am fine with switching to Yb_3 given that most Yb exists in 3+ oxidation state.

@janosh
Copy link
Member Author

janosh commented May 2, 2023

This docs page needs updating. It incorrectly states we use Yb. It even lists "thermo data off with Yb_2" as the reason not to use Yb_2 even though VASP recommends. 🤦

@shyuep
Copy link
Member

shyuep commented May 2, 2023

The docs page need to be updated for sure. But the docs seem to be based on the old HT framework at MIT. When we did MP, there was a deliberate change in PSP used. Anyway, like I said, no issue with switching to Yb3+.

@janosh
Copy link
Member Author

janosh commented May 2, 2023

@munrojm Change request for docs page submitted on gitbooks.

@munrojm
Copy link
Member

munrojm commented May 2, 2023

@janosh merging now

@mkhorton
Copy link
Member

mkhorton commented May 2, 2023

Although if tales are correct, @arosen93 originally brought this up with @mkhorton in Oct 2021?

I don’t recall, but I believe it. The consequence of changing the MP Input Set is that current data on MP will the be inconsistent with the MP Input Set; since a lot of people generate data intentionally to be compatible with MP, this can cause a lot of downstream problems (even in this case, where the change is sensible and necessary).

Around that time we were also talking about reviewing other pseudopotential choices in MP, eg some pseudopotentials we’re not used because of ghost states (perhaps Na? I forget), but these issues were later fixed in the newer 54 pseudopotentials that the MP SCAN Input Set uses. The SCAN Input Set presented an opportunity to cleanly make this change. However this was not pursued, I think more out of conservativeness than anything.

All this to say, I’m glad this change was made, but if I could offer a viewpoint to the MP team, it’s that a new data release to replace the Yb data should also be done promptly (although I realise this may not be possible!), as well as a louder mention of this change in the relevant places (eg docs changelog, or a banner on the linked docs page) might be a good idea too, to let people know this change is coming.

@munrojm
Copy link
Member

munrojm commented May 2, 2023

Just an FYI for everyone here that I am moving to re-calculate all the Yb compounds right now. The plan is to stop working on the current MP build to get these done and incorporated.

@janosh
Copy link
Member Author

janosh commented May 2, 2023

as well as a louder mention of this change in the relevant places (eg docs changelog, or a banner on the linked docs page) might be a good idea too, to let people know this change is coming.

Yes this is definitely planned! 👍

new data release to replace the Yb data should also be done promptly (although I realise this may not be possible!)

This is also planned but the timeline is less firm.

@janosh
Copy link
Member Author

janosh commented May 2, 2023

Lol, simultaneous posts. 😄

I stand corrected. Timeline for updating Yb compounds is very firm. 🚀

@janosh janosh pinned this issue May 2, 2023
@janosh
Copy link
Member Author

janosh commented May 2, 2023

@mkhorton Any suggestions for this banner on the PSP docs page?

Screenshot 2023-05-02 at 15 14 49

@mkhorton
Copy link
Member

mkhorton commented May 2, 2023

Looks perfect :)

@mkhorton
Copy link
Member

mkhorton commented May 2, 2023

Perhaps additional information to add somewhere might simply be some screenshots or descriptions of the two relevant chemical systems to demonstrate the difference. It might help justify the change, rather than "because we say so", as well as point(s)-of-contact for who investigated the issue. I say this as someone who's wished this information was available with previous decisions, but where I was unable to track down additional context.

@janosh
Copy link
Member Author

janosh commented May 3, 2023

...well as point(s)-of-contact for who investigated the issue. I say this as someone who's wished this information was available with previous decisions, but where I was unable to track down additional context.

Definitely! That's the reason I tried to @-mention all people I know have knowledge of this matter in the original issue above. I made sure all places documenting this change link back to this issue so hopefully people in the future can follow the trail to determine who to contact with questions. What I wrote above is most of the context I have. Of course, others are welcome to add.

Another tidbit I learned later is that prompted by A-lab results, @mattmcdermott very recently tried to re-run a bunch of Yb compounds (< 10?) using Yb instead of Yb_2. All of them failed, corroborating the claim that the Yb PSP is not usable in high throughput.

@mattmcdermott
Copy link
Member

mattmcdermott commented May 3, 2023

@janosh yep, I ran 20ish compounds with the Yb pseudopotential that all failed (including Yb2O3, Yb, Yb2MoO6..) I am not a great VASP debugger, but I was usually getting PotimErrorHandler and PositiveEnergyErrorHandler in custodian. Eventually every job fizzled after reaching a maximum of 5 errors

@mattmcdermott
Copy link
Member

Also I meant to send this earlier -- this is not the most rigorous comparison, but here is a look at the Yb-Mo-O phase diagram (GGA/GGA+U) before and after I recomputed the Yb entries with the Yb_3 pseudopotential and applied previously fitted corrections (i.e., oxide, +U corrections).

Big differences -- notably, the very common Yb2O3 moves to be stable after previously being >200 meV/atom above the hull. Also stabilizes two ternary phases and destabilizes YbMoO4 greatly

Screenshot 2023-05-03 at 4 52 34 PM
Screenshot 2023-05-03 at 4 49 16 PM

@chiang-yuan
Copy link
Contributor

I don't know if I am experienced enough for this conversation, but I was able to get YbCl3 relaxation converged using Yb_3 recently. But it is difficult to get YbCl2 converged and the formation energy is quite off from the experimental value. One possible reason our lab found might be the nonmagnetic state the system gets converged to but they should be converged to magnetic state.

@janosh
Copy link
Member Author

janosh commented May 5, 2023

I don't know if I am experienced enough for this conversation

Any and all relevant anecdotes are welcome! The more data we have, the better our decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linting Linting and quality assurance vasp Vienna Ab initio Simulation Package
Projects
None yet
6 participants