Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure.replace_species leaves label intact resulting in confusing/misleading label #3658

Closed
stefsmeets opened this issue Feb 26, 2024 · 1 comment · Fixed by #3672
Closed

Structure.replace_species leaves label intact resulting in confusing/misleading label #3658

stefsmeets opened this issue Feb 26, 2024 · 1 comment · Fixed by #3672

Comments

@stefsmeets
Copy link
Contributor

stefsmeets commented Feb 26, 2024 •
edited
Loading

I noticed that performing a Structure.replace_species operation leaves the label intact, leading to a misleading label or a confusing end-user experience (for example, replacing Au with {"Au": 0.5, "Cu": 0.5} will leave the label as Au). Do you have any thoughts on this @stefsmeets?

Originally posted by @mkhorton in #3183 (comment)
@stefsmeets
Copy link
Contributor Author

stefsmeets commented Feb 26, 2024 •
edited
Loading

Proposed solution in #3183 (comment): update the label to Composition({"Au": 0.5, "Cu": 0.5}).formula

@stefsmeets stefsmeets mentioned this issue Mar 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset label for sites changed by Structure.replace_species() stefsmeets/pymatgen
1 participant
@stefsmeets