Fix ValueError: not enough values to unpack in PDPlotter if no unstable entries in PD #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in PDPlotter: unstable_entries, unstable_coords = zip(*self.pd_plot_data[2].items())
self = <test_phase_diagram.PDPlotterTest testMethod=test_plotly_plots>
def test_plotly_plots(self):
# Also very basic tests. Ensures callability and 2D vs 3D properties.
> self.plotter_binary_plotly.get_plot()
pymatgen/analysis/tests/test_phase_diagram.py:914:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pymatgen/analysis/phase_diagram.py:2226: in get_plot
stable_marker_plot, unstable_marker_plot = self._create_plotly_markers(label_uncertainties)
pymatgen/analysis/phase_diagram.py:3026: in _create_plotly_markers
unstable_props = get_marker_props(unstable_coords, unstable_entries, stable=False)
pymatgen/analysis/phase_diagram.py:2979: in get_marker_props
energy = round(self._pd.get_form_energy_per_atom(entry), 3)
pymatgen/analysis/phase_diagram.py:575: in get_form_energy_per_atom
return self.get_form_energy(entry) / entry.composition.num_atoms
jmmshn
pushed a commit
to jmmshn/pymatgen
that referenced
this pull request
Mar 30, 2023
…le entries in PD (materialsproject#2908) * fix ValueError: not enough values to unpack (expected 2, got 0) in PDPlotter: unstable_entries, unstable_coords = zip(*self.pd_plot_data[2].items()) * add test to prevent regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2885.
933d3eb fix ValueError: not enough values to unpack (expected 2, got 0)
f654d9f add test to prevent regression