Breaking: change Yb pseudo-potential on all VASP input sets from Yb_2 to Yb_3
#2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should one mark this as a breaking change? It's a rather drastic change. |
|
Yes, this change will be highlighted in the next release notes. I'll also change the PR title to make this clearer. |
janosh
changed the title
Yb pseudo-potential on all VASP input sets: Yb_(2->3)
janosh
changed the title
Yb pseudo-potential on all VASP input sets: Yb_(2->3)Yb pseudo-potential on all VASP input sets from Yb_2 to Yb_3
|
I would suggest you document the change to Yb_3 in the input sets yaml themselves. E.g., |
|
@shyuep Excellent suggestion! |
janosh
added a commit
that referenced
this pull request
May 2, 2023
…d link to GH issue as suggested in #2969 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2968.