Hide all type-hint-only imports behind if TYPE_CHECKING
#2992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 main motivations for this change:
pymatgen.analysis.defects
if they were previously in a test's import stack but only used for type hintsTYPE_CHECKING=False
at run time means some modules won't have to be imported. somewhat negated by the annoyingly long import time of the std libtyping
module itself but that has been steadily coming down with newer Python versions.