Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unignore ruff PD011 #3020

Merged
merged 5 commits into from
May 30, 2023
Merged

Unignore ruff PD011 #3020

merged 5 commits into from
May 30, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented May 30, 2023

c535f49 ruff unignore PD011 (pandas-use-of-dot-values)
7d3eba4 drop .values where not needed, else replace with .to_numpy(), noqa false positives

pandas.DataFrame().values is deprecated and slated for removal in a future pandas version.

@janosh janosh enabled auto-merge (squash) May 30, 2023 01:01
@janosh janosh added linting Linting and quality assurance housekeeping Moving around or cleaning up old code/files labels May 30, 2023
janosh added 3 commits May 29, 2023 18:11
       assert ss["force_eval"]["dft"]["poisson"].get("periodic").to_numpy()[0].upper() == "NONE"
E       AttributeError: 'Keyword' object has no attribute 'to_numpy'
@janosh janosh merged commit 3c91e69 into master May 30, 2023
@janosh janosh deleted the unignore-ruff-PD011 branch May 30, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Moving around or cleaning up old code/files linting Linting and quality assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant