Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AseAtomsAdaptor: Retain tags property when interconverting Atoms and Structure/Molecule #3151

Merged
merged 7 commits into from
Jul 22, 2023
Merged

AseAtomsAdaptor: Retain tags property when interconverting Atoms and Structure/Molecule #3151

merged 7 commits into from
Jul 22, 2023

Conversation

Andrew-S-Rosen
Copy link
Member

Currently, the .tags property of the ASE Atoms object is lost when interconverting between ASE Atoms and Pymatgen Structure/Molecule. I adopted the solution by @brookwander in ulissigroup/catapalt#2 to ensure the tags do not get lost.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Retain tags property when interconverting Atoms and Structure/Molecule in AseAtomsAdaptor AseAtomsAdaptor: Retain tags property when interconverting Atoms and Structure/Molecule Jul 12, 2023
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft July 12, 2023 22:13
@brookwander
Copy link

thanks @arosen93 !

@janosh janosh added enhancement A new feature or improvement to an existing one io Input/output functionality ase Atomic simulation environment labels Jul 13, 2023
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review July 21, 2023 23:44
@Andrew-S-Rosen
Copy link
Member Author

@janosh --- why does ruff hate me? :(

@janosh
Copy link
Member

janosh commented Jul 22, 2023

Looks like ruff just had a new release that finds new issues on master. So nothing to do with your changes. Does this still need testing?

@Andrew-S-Rosen
Copy link
Member Author

Ah I see. No, this should be done!

@janosh janosh merged commit 5d6f566 into materialsproject:master Jul 22, 2023
@Andrew-S-Rosen Andrew-S-Rosen deleted the rase branch July 24, 2023 16:07
@janosh janosh mentioned this pull request Feb 14, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ase Atomic simulation environment enhancement A new feature or improvement to an existing one io Input/output functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrew-S-Rosen @brookwander @janosh