Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Composition repr #3182

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Better Composition repr #3182

merged 4 commits into from
Jul 25, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jul 25, 2023

Closes #3181.

1d3ff84 include oxidation states in Composition.__repr__
26b3b5b delete unused doctest.testmod() if __name__ == "__main__"
d2aed40 add tests for Composition.__repr__ and __str__

@janosh janosh added enhancement A new feature or improvement to an existing one tests Issues with or changes to the pymatgen test suite core Pymatgen core labels Jul 25, 2023
@janosh janosh enabled auto-merge (squash) July 25, 2023 18:46
@janosh janosh merged commit d97e77d into master Jul 25, 2023
@janosh janosh deleted the better-comp-repr branch July 25, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core enhancement A new feature or improvement to an existing one tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to improve Composition.__repr__
1 participant