Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Structure tests #3197

Merged
merged 15 commits into from
Aug 1, 2023
Merged

Improve Structure tests #3197

merged 15 commits into from
Aug 1, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jul 31, 2023

Most notable user-facing change: add in_place: bool = True keyword to Structure.make_supercell() and return the supercell.

a70f4c4 add Structure/Molecule.sites setter, move @property to SiteCollection
7f510ca don't use implementation detail (Structure|Molecule)._sites
c5052a2 rename StructureTest.structure attr to struct
28a895f add IStructureTest.test_sites_setter
185d2cb fix mypy
94f4413 test translate/rotate_sites IndexError if "list index out of range"
2ffd3bb tweak doc strings
f482ba0 test inverse translate_sites operations leave structure unchanged
7197592 Structure.make_supercell() add in_place: bool = True keyword and return supercell structure
638c095 test make_supercell in_place=True and False

@janosh janosh added enhancement A new feature or improvement to an existing one tests Issues with or changes to the pymatgen test suite breaking Breaking change core Pymatgen core and removed breaking Breaking change labels Jul 31, 2023
@janosh janosh enabled auto-merge (squash) August 1, 2023 03:14
@janosh janosh merged commit 8990032 into master Aug 1, 2023
@janosh janosh deleted the improve-structure-tests branch August 1, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core enhancement A new feature or improvement to an existing one tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant