Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small bugfix for the MPMD vasp input set. The input parameter
time_step
was added in fabdd27 (it was in the docstring before that), but it was not added as a class attribute, leading to anNotImplementedError
raised when trying to convert the object to a dict:Major changes:
time_step
is now usable and is passed on toPOTIM
. It defaults to None, in which case, the MPMDSet behaves as previously andPOTIM
is set to 0.5fs for compounds containing hydrogen, 2fs for anything else.Both the time steps, as well as the dict conversion are tested in a new unit test for the MPMD set.
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)