-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lobsterin dict inheritance and treat \t in lobsterins correctly #3439
Conversation
@naik-aakash , I have started with the fix. I will test methods like update, delete as well. We could also directly implement a fix for reading lobsterins with \t |
Thanks! Thats great. So you will also fix the |
@naik-aakash You are invited to contribute to this PR. I am in the train today and I don't really expect to be able to work much on the remote connection 😅 |
Ah okay. Just got the invitation. Thank you 😄 |
I think I have now correctly implemented the inheritance from a UserDict. All standard functionalities work. Things left to do:
|
I think treating I also tested if LOBSTER is able to read lobsterin files with |
Update: LOBSTER can read cohpsteps as a float and integer. It will automatically round to the next larger integer independent on whether it is a float or an integer (in versions 4.1.0 and 5.0.0). I think it doesn't really matter that we print a float... Also, I think this behavior of LOBSTER is a bit unexpected (instead of 308, Lobster uses 309). |
@janosh , I think this would be ready for review in case you have time. |
Summary
Closes #3437 and #3438.
Inheritance of the dict was not carried out correctly. I have started here with inheriting from UserDict. We will add more tests to avoid similar issues in the future.