Module-scoped imports #3464
Merged
Module-scoped imports #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
linting
|
There are good reasons to not use module scope in many instances. E.g., when a function is rarely used. |
…en.core.structure.py
…tion' from partially initialized module 'pymatgen.transformations.advanced_transformations'
|
There are 2 more conditions for it to make sense to have function-scoped imports. The import must be expensive and not already in the import tree. I'm looking out for that in these refactors but those 3 conditions almost never coincide. |
janosh
added
imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3462.