Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to PhononDosPlotter and PhononBSPlotter #3479

Merged
merged 10 commits into from
Nov 19, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 19, 2023

6bb14f9 PhononDosPlotter.get_plot add legend keyword to customize legend
df68ddc improve UX by preventing common user mistake in PhononDosPlotter passing DOS as 1st arg
4245948 Remove debug logging statements in PhononBSPlotter._make_ticks
a6df2a4 add class Kpoint type annos
f8def84 Add label setter for Kpoint class
408ba30 add repr for PhononBandStructureSymmLine and tests for it
43ec584 pretty print kpoint label "GAMMA" as r"$\Gamma$" in PhononBSPlotter
8f72e65 fix phonon/test_dos.py test class names
c4ebf60 better variable names
16d236a add PhononDos.repr method and test it

@janosh janosh added enhancement A new feature or improvement to an existing one data viz PRs and issues about pymatgen plotting functionality phonon Lattice vibrations labels Nov 19, 2023
@janosh janosh merged commit c8154cd into master Nov 19, 2023
20 of 22 checks passed
@janosh janosh deleted the phonon-bs-dos-plotters branch November 19, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data viz PRs and issues about pymatgen plotting functionality enhancement A new feature or improvement to an existing one phonon Lattice vibrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant