Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pymatgen/symmetry/groups.py module-scoped SymmOp import causing circular import #3486

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Revert pymatgen/symmetry/groups.py module-scoped SymmOp import causing circular import #3486

merged 1 commit into from
Nov 27, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 27, 2023 •
edited
Loading

Closes #3485.

Apologies! I broke this in #3464.

@janosh janosh added fix Bug fix PRs symmetry Space groups and the like imports Import changes and formatting labels Nov 27, 2023
@janosh janosh merged commit 3a58824 into master Nov 27, 2023
20 of 22 checks passed
@janosh janosh deleted the fix-gh-3485 branch November 27, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Bug fix PRs imports Import changes and formatting symmetry Space groups and the like
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circular import when importing SpaceGroup
1 participant
@janosh