-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing MPSCANRelaxSet.yaml
parameters and alphabetize
#3615
Conversation
MPSCANRelaxSet.yaml
parametersMPSCANRelaxSet.yaml
parameters and alphabetize
@esoteric-ephemera --- I see the thumbs up. Does that mean this is good to go, or are you still planning to review this? |
Looks good to me. I think I believe there was also some talk about switching |
@Andrew-S-Rosen thanks for putting this together! @mkhorton, yeah for the new input sets, putting them in a separate PR would be good. I'll reach out to the foundation soonish with that |
Great, thank you both! I also agree that some minor modifications should be made but that will be elsewhere. @shyuep, I think we have the necessary blessings for this one. |
@janosh should I update the hash? |
yes please |
Tagging @esoteric-ephemera for review, @utf for context, and @shyuep & @mkhorton as code owners of the MP sets.
This PR ensures that the
MPSCANRelaxSet.yaml
in Pymatgen matches theBaseMPR2SCANRelaxSet.yaml
used in Atomate2 (and thereby, in MP production calculations). Namely, theMPSCANRelaxSet.yaml
in pymatgen was missing the "sensible defaults" added by @esoteric-ephemera, which includes:ISMEAR: 0
,KSPACING: 0.22
,SIGMA: 0.05
. Everything else is just a reordering for alphabetization purposes.