Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CODEOWNERS #3616

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

Andrew-S-Rosen
Copy link
Member

This PR adds a CODEOWNERS file (details here) that will automatically request a review from the specified code owner when a corresponding file is edited. Notably, the PR can still be merged without their review, but hopefully this will help keep folks informed for codes they have heavily developed and rely on daily.

This PR adds a `CODEOWNERS` file (details [here](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners)) that will automatically request a review from the specified code owner when a corresponding file is edited. Notably, the PR can still be merged without their review, but hopefully this will help keep folks informed for codes they have heavily developed and rely on daily.

Signed-off-by: Andrew S. Rosen <asrosen93@gmail.com>
@shyuep shyuep enabled auto-merge (squash) February 9, 2024 20:12
@shyuep shyuep disabled auto-merge February 9, 2024 20:12
@shyuep shyuep merged commit 6a0b7ee into materialsproject:master Feb 9, 2024
22 checks passed
@janosh janosh added the contributing Issues about how to contribute, report errors, submit features label Feb 9, 2024
@Andrew-S-Rosen
Copy link
Member Author

Ah, you beat me to making a comment, @shyuep. It looks like only those with write permissions to the repo are valid as CODEOWNERS, so it can't just me an arbitrary contributor. Feel free to remove my name under the ASE line.

@shyuep
Copy link
Member

shyuep commented Feb 9, 2024

I can grant you write permissions.

@Andrew-S-Rosen
Copy link
Member Author

Sure, that works too. 👍

@JaGeo
Copy link
Member

JaGeo commented Feb 9, 2024

I was very excited about this feature before seeing the 2nd comment. 😅

@shyuep
Copy link
Member

shyuep commented Feb 9, 2024

@JaGeo I am happy to add you as a codeowner. For lobster?

@JaGeo
Copy link
Member

JaGeo commented Feb 9, 2024

@shyuep , thank you! This would be great, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributing Issues about how to contribute, report errors, submit features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants