Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return self from all SiteCollection/Structure/Molecule in-place modification methods #3623

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Return self from all SiteCollection/Structure/Molecule in-place modification methods #3623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
695f329
return self from Structure modify methods
janosh Feb 14, 2024
4479da0
fix missing NotImplementedError in abstractmethod SiteColl.get_distance
janosh Feb 14, 2024
7977726
test return value of Structure modify methods
janosh Feb 14, 2024
dbbfb61
fix SiteCollection.replace_species doc str had no ret val
janosh Feb 14, 2024
20a1f98
return self from SiteCollection modify methods
janosh Feb 14, 2024
a2f05bb
return self from Molecule modify methods
janosh Feb 14, 2024
1bc1584
test return value of Molecule modify methods
janosh Feb 14, 2024
b36f486
return self in Slab.add_adsorbate_atom method and add test
janosh Feb 14, 2024
1af46b1
rename test_add_oxidation_states_by_guess to match method name
janosh Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading