Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Lobsterenv improvements #3624

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Breaking Lobsterenv improvements #3624

merged 2 commits into from
Feb 18, 2024

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Feb 14, 2024 •
edited
Loading

Todo

  • Adapt LobsterNeighbours to work using pymatgen objects instead of file path
  • Rename args to use lowercase
  • Add test for new functionality of working with pymatgen objects
  • Align lightstructure environment output to match other types
  • Add test for adapted lightstructure environment outputs

@naik-aakash
Copy link
Contributor Author

naik-aakash commented Feb 14, 2024 •
edited
Loading

@JaGeo , Tagging you here. Let us know if you have any suggestions on this change 😃

@JaGeo
Copy link
Member

JaGeo commented Feb 14, 2024 •
edited
Loading

From my side, this is fine. A breaking change is probably okay here as not many people are using LobsterEnv directly

@janosh janosh added breaking Breaking change lobster Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction) api Application programming interface labels Feb 18, 2024
janosh
janosh approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @naik-aakash, much appreciated!

@janosh janosh merged commit bd88e0d into materialsproject:master Feb 18, 2024
22 checks passed
@naik-aakash naik-aakash mentioned this pull request Feb 21, 2024
Merged
1 task
@janosh janosh changed the title [WIP] Lobsterenv improvements Breaking Lobsterenv improvements Apr 10, 2024
@janosh janosh mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

@JaGeo JaGeo JaGeo approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
api Application programming interface breaking Breaking change lobster Lobster package (Local Orbital Basis Suite Towards Electronic-Structure Reconstruction)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naik-aakash @JaGeo @janosh