Add types annotations for core.interface
#3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move dunder methods to the top add more types and tweaks relocate more dunder methods to top more types and format tweaks fix type error add types for composition help fix materialsproject#3792 (comment) reverse compare order for readability Revert "reverse compare order for readability" This reverts commit 05ea23a. Revert "help fix materialsproject#3792 (comment)" This reverts commit cae7aed. add types for `core.bonds` finish `core.ion` add some types revert non-interface changes
DanielYang59
force-pushed
the
add-types-core-interface
branch
from
501764f to
579083b
Compare
|
Not working on this for now, would reopen it later. |
DanielYang59
commented
Jun 3, 2024
DanielYang59
commented
Jun 3, 2024
DanielYang59
commented
Jun 3, 2024
|
@janosh Would appreciate it if you could review this at your convenience, thanks! |
janosh
suggested changes
Jun 4, 2024
There was a problem hiding this comment.
thanks @DanielYang59! this all looks good. just 1 minor comment regarding the test change
|
@janosh Just ping you again in case it got forgotten :) No rush |
janosh
suggested changes
Jun 6, 2024
DanielYang59
commented
Jun 6, 2024
| from pymatgen.core import Element | ||
| from pymatgen.util.typing import CompositionLike, Matrix3D, MillerIndex, Tuple3Floats, Vector3D | ||
|
|
||
| Tuple4Ints = tuple[int, int, int, int] |
There was a problem hiding this comment.
I put it here because it doesn't seem to be needed by other code, tuple[int, int, int, int] doesn't seem to be commonly used. But we could relocate it if needed
There was a problem hiding this comment.
ah, didn't see that. i would relocate right away
|
Thanks for reviewing! Appreciate that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
core.interfaceClassVarNew custom type aliases