ST4: 4065+ HTMLSheet Updates #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheSecEng: please add to the above message |
fix: strip comments fix: frontmatter because mdpopups wont support nl2br soon fix: trying to update non-existent previews
jrappen
reviewed
May 4, 2020
jrappen
reviewed
May 4, 2020
|
ST Build 4074 and mdpopups Code is fine as is, but requirement should be bumped. |
rwols
reviewed
Aug 27, 2020
| # FIXME: how do I choose how many workers I want? | ||
| # - Does thread pool reuse threads or does it stupidly throw them out? | ||
| # - (we could implement something of our own) | ||
| executor = concurrent.futures.ThreadPoolExecutor(max_workers=5) |
There was a problem hiding this comment.
This is overkill for this sort of plugin.
rwols
reviewed
Aug 27, 2020
| ) | ||
| return "{}{}".format( | ||
| "data:image/png;base64,", b64encode(image_content).decode("utf-8") | ||
| ) |
There was a problem hiding this comment.
Looks like you want to use asyncio instead of a ThreadPoolExecutor (which is IMO completely the wrong tool for this job).
|
Why did work on this stopped ? |
I just am in the middle of moving and what not. I’d be happy to get help with it. I’ll start working on it again when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a ST4 only branch
4074Will update the Package Control Channel to support ST3 and ST4 tags and set appropriate ST4 version requirement
Major Changes
2markdown.pyin favor of Mdpopupsmarkdown2html.pyimplementsImageParser.pyadd_on_changefor monitoring theSETTING_DELAY_BETWEEN_UPDATESto update the delay in real time. (Could be back ported)
MdlpEraseCommandfor erasing a view when called fromon_pre_closeShould probably be implemented on the ST3 branch to fix a bug in which EventListener doesn't have aeditobjectMarkdownLivePreview/MarkdownLivePreview.py
Lines 130 to 135 in ec27d98
PREVIEW_VIEWShash map to allow for multiple markdown previews (Could be back ported)syntaxsetting that allows you to enable the plugin on different syntax files (Could be back ported)Fixes
fixes #94 - Fixed with ST4 Changes. Likely can fix in ST3 by using Mdpopups but not HTMLSheet
fixes #98 via facelessuser/sublime-markdown-popups@5c65d6f
fixes #103
fixes #104
fixes #106