You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #64, we should remove all UMD and iife-related code and leave it for Rollup to produce UMD, CJS and EMS builds. Along the way, we could rebase the source to be in ES6+ and keep the source in ES Modules format so that importing parties could benefit from tree-shaking etc. Publishing methods as separate packages (lodash-style) is also an option which would solve #64.
Currently, the iife wrapper in the source contains this and it throws errors in Rollup:
That's what I'm talking about — if we cleaned the source to be in ES Modules (with import/export) and left up to Rollup to produce the UMD build, we could improve the user experience.
The fork https://www.npmjs.com/package/lean-he already went to the right direction, removing the iife wrapper but it still lacks proper Rollup setup with UMD, CJS and ESM builds.
@mathiasbynens please advise, do you see value in this path or should we forget about setting up the Rollup and close this issue.
The text was updated successfully, but these errors were encountered:
Related to #64, we should remove all UMD and iife-related code and leave it for Rollup to produce UMD, CJS and EMS builds. Along the way, we could rebase the source to be in ES6+ and keep the source in ES Modules format so that importing parties could benefit from tree-shaking etc. Publishing methods as separate packages (lodash-style) is also an option which would solve #64.
Currently, the iife wrapper in the source contains
this
and it throws errors in Rollup:That's what I'm talking about — if we cleaned the source to be in ES Modules (with
import
/export
) and left up to Rollup to produce the UMD build, we could improve the user experience.The fork https://www.npmjs.com/package/lean-he already went to the right direction, removing the iife wrapper but it still lacks proper Rollup setup with UMD, CJS and ESM builds.
@mathiasbynens please advise, do you see value in this path or should we forget about setting up the Rollup and close this issue.
The text was updated successfully, but these errors were encountered: