Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 5.0 #27

Closed
StopMotionCuber opened this issue Mar 19, 2024 · 1 comment · Fixed by #29
Closed

Add support for Django 5.0 #27

StopMotionCuber opened this issue Mar 19, 2024 · 1 comment · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@StopMotionCuber
Copy link

Right now this tool is not allowed with Django 5.0, as per dependencies it requires Django 3.x or 4.x. Therefore installing django-contract-tester leads to a downgrade of Django (with 5.0 installed).

For my use case it works flawlessly with Django 5.0, so it would be great having that also supported in the dependencies. I'm not sure whether it makes sense to set a maximum Django version in the dependencies at all or whether going with >= 3 would be fine.

@maticardenas
Copy link
Owner

Hi @StopMotionCuber, thanks for bringing this to attention.

I agree we should add 5.0 to be allowed in the dependencies. I will revisit actually current django version constraints at pyproject.toml and do some tests, ideally probably it should align with defined django compatibility

@maticardenas maticardenas self-assigned this Mar 28, 2024
@maticardenas maticardenas added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants