Skip to content

Commit

Permalink
fix : wrong chainID on rpc (#1030)
Browse files Browse the repository at this point in the history
  • Loading branch information
0xsharma committed Oct 6, 2023
1 parent 2e896e2 commit 784be5f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions internal/ethapi/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -1742,6 +1742,7 @@ func newRPCTransactionFromBlockIndex(b *types.Block, index uint64, config *param
// If the transaction is a bor transaction, we need to set the hash to the derived bor tx hash. BorTx is always the last index.
if borReceipt != nil && index == uint64(len(txs)-1) {
rpcTx.Hash = borReceipt.TxHash
rpcTx.ChainID = nil
}

return rpcTx
Expand Down
1 change: 1 addition & 0 deletions internal/ethapi/bor_api.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ func (s *BlockChainAPI) appendRPCMarshalBorTransaction(ctx context.Context, bloc
// newRPCTransaction calculates hash based on RLP of the transaction data.
// In case of bor block tx, we need simple derived tx hash (same as function argument) instead of RLP hash
marshalledTx.Hash = txHash
marshalledTx.ChainID = nil
fields["transactions"] = append(formattedTxs, marshalledTx)
} else {
fields["transactions"] = append(formattedTxs, txHash)
Expand Down

0 comments on commit 784be5f

Please sign in to comment.