Fix reversed order of values in unit tests and test removal of settin…

…g u.path to rawPath (otherwise why do we need rawPath at all) seems like there were work arounds done here in bioth the unit tests AND the makeURL but logic needs to be examined
maticnetwork · Jan 14, 2024 · 7f9747a · 7f9747a
1 parent b3a5bcd
commit 7f9747a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/consensus/bor/heimdall/client.go b/consensus/bor/heimdall/client.go
@@ -421,7 +421,6 @@ func makeURL(urlString, rawPath, rawQuery string) (*url.URL, error) {
 		return nil, err
 	}
 
-	u.Path = rawPath
 	u.Path = path.Join(u.Path, rawPath)
 	u.RawQuery = rawQuery
 

diff --git a/consensus/bor/heimdall/client_test.go b/consensus/bor/heimdall/client_test.go
@@ -399,7 +399,7 @@ func TestSpanURL(t *testing.T) {
 	const expected = "http://bor0/bor/span/1"
 
 	if url.String() != expected {
-		t.Fatalf("expected URL %q, got %q", url.String(), expected)
+		t.Fatalf("expected URL %q, got %q", expected, url.String())
 	}
 }
 
@@ -414,6 +414,6 @@ func TestStateSyncURL(t *testing.T) {
 	const expected = "http://bor0/clerk/event-record/list?from-id=10&to-time=100&limit=50"
 
 	if url.String() != expected {
-		t.Fatalf("expected URL %q, got %q", url.String(), expected)
+		t.Fatalf("expected URL %q, got %q", expected, url.String())
 	}
 }