From f046a0188239d6aacc8bf99ea77c86cde7c59f79 Mon Sep 17 00:00:00 2001 From: Manav Darji Date: Thu, 29 Aug 2024 15:09:01 +0530 Subject: [PATCH] core: validate chain before writing block --- core/blockchain.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/core/blockchain.go b/core/blockchain.go index b1fec32cf3..7b47d92839 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -2230,6 +2230,20 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error) status WriteStatus ) + // Before the actual db insertion happens, verify the block against the whitelisted + // milestone and checkpoint. This is to prevent a race condition where a milestone + // or checkpoint was whitelisted while the block execution happened (and wasn't + // available sometime before) and the block turns out to be inavlid (i.e. not + // honouring the milestone or checkpoint). Use the block itself as current block + // so that it's considered as a `past` chain and the validation doesn't get bypassed. + isValid, err = bc.forker.ValidateReorg(block.Header(), []*types.Header{block.Header()}) + if err != nil { + return it.index, err + } + if !isValid { + return it.index, whitelist.ErrMismatch + } + if !setHead { // Don't set the head, only insert the block _, err = bc.writeBlockWithState(block, receipts, logs, statedb)