Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1107, #1085 PR missing due to revert #1192

Closed
bbaktaeho opened this issue Mar 19, 2024 · 5 comments
Closed

#1107, #1085 PR missing due to revert #1192

bbaktaeho opened this issue Mar 19, 2024 · 5 comments
Assignees

Comments

@bbaktaeho
Copy link
Contributor

bbaktaeho commented Mar 19, 2024

#1107, #1085 PRs were included in v1.2.3, but they have all been removed in v1.2.8. It seems they were missing due to a revert that happened previously. Please verify.

@temaniarpit27
Copy link
Contributor

Will check how they got removed in latest version but it will definitely be included in the upcoming version.
Thanks for bring this up

@bbaktaeho
Copy link
Contributor Author

ok. thanks @temaniarpit27

@CitizenSearcher
Copy link

@temaniarpit27 PR https://github.com/maticnetwork/bor/pull/1109/files Is also missing. I believe this PR will have a very positive impact on small network reorgs: #1118

@temaniarpit27
Copy link
Contributor

This is coming in next release

@manav2401
Copy link
Contributor

Hey @bbaktaeho, I think these PRs never made it to any release (which is expected because we did a code freeze for the hard fork release and only included hot fixes in the subsequent releases). If you see this line in v1.2.3, it still has the older code. These changes will be included in upcoming release. Closing this for now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants