EIP7212 / PIP27 #1069
Merged
EIP7212 / PIP27 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fb89b61cdc2ccf6bda9f77f72315e01fa4ffb7d7)
(cherry picked from commit a8c0a2e05c7b6cafa16d296f91da8cb651bf9d46)
(cherry picked from commit c0554c0764a2c021689e8d73b36987b67c954f0c)
(cherry picked from commit 6c7028a9043f65f0a3596be4a429be4e03d0eb89)
(cherry picked from commit d245194e7724c2a7d153945cc86c9aa8d0b522b3)
(cherry picked from commit 066a31f6345c8a04a4ebf84efd8c80d87107e6d5)
(cherry picked from commit ec17e788ade3f43ded67c014f019770634f32a7c)
(cherry picked from commit f5b6d7e9954cae87348e21525210affda09297c1)
(cherry picked from commit 2820903f591365b17a4c3bdb36bd49ee2d84054c)
(cherry picked from commit 1be1875156e2a5a417801deb59546b167e5456c6)
(cherry picked from commit 21f4932c9bbb8664cf7b3e3c3602b6a48c747893)
(cherry picked from commit 98f10b0d5e358075d03b76834cd30c97f4fbdfe1)
(cherry picked from commit cec0b058115282168c5afc5197de3f6b5479dc4a)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1069 +/- ##
========================================
Coverage 56.01% 56.01%
========================================
Files 658 658
Lines 114446 114479 +33
========================================
+ Hits 64111 64130 +19
- Misses 46481 46490 +9
- Partials 3854 3859 +5 ☔ View full report in Codecov by Sentry. |
Raneet10
approved these changes
Nov 30, 2023
ulerdogan
reviewed
Nov 30, 2023
0xKrishna
approved these changes
Jan 12, 2024
yperbasis
reviewed
Jan 17, 2024
| common.BytesToAddress([]byte{7}): &bn256ScalarMulIstanbul{}, | ||
| common.BytesToAddress([]byte{8}): &bn256PairingIstanbul{}, | ||
| common.BytesToAddress([]byte{9}): &blake2F{}, | ||
| common.BytesToAddress([]byte{0x0a}): &kzgPointEvaluation{}, |
There was a problem hiding this comment.
kzgPointEvaluation should probably not be here because it's part of EIP-4844 and EIP-4844 was excluded from the Napoli hardfork.
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jan 17, 2024
Initial support of the upcoming Napoli hard fork on Polygon – see [PIP-33](https://forum.polygon.technology/t/pip-33-napoli-upgrade). Per [PIP-31](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-31.md), it parallels the [Cancun](https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/cancun.md) upgrade of Ethereum, but does not include [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788), [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844), [EIP-7516](https://eips.ethereum.org/EIPS/eip-7516). In other words, Napoli includes [EIP-1153](https://eips.ethereum.org/EIPS/eip-1153), [EIP-5656](https://eips.ethereum.org/EIPS/eip-5656), [EIP-6780](https://eips.ethereum.org/EIPS/eip-6780) from Cancun. This PR implements [PIP-31](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-31.md), [PIP-16: Transaction Dependency Data](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-16.md) (by merging `ParallelUniverseBlock` into `NapoliBlock`; the bulk of PIP-16 was implemented in PR #8037), and [PIP-27: Precompiled for secp256r1 Curve Support](https://github.com/maticnetwork/Polygon-Improvement-Proposals/blob/main/PIPs/PIP-27.md) ([EIP-7212](https://eips.ethereum.org/EIPS/eip-7212); see also maticnetwork/bor#1069 & ethereum/go-ethereum#27540). --------- Co-authored-by: Anshal Shukla <shukla.anshal85@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulls changes from PR#27540, introduces EIP-7212 or PIP-27. This PR currently just cherry-pick the commits from the upstream.
Changes
Breaking changes
We will need a HF to enable this feature
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it