-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add : amoy flags and genesis #1072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few minor comments. Nothing affecting the main logic.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1072 +/- ##
===========================================
+ Coverage 57.01% 57.04% +0.03%
===========================================
Files 650 650
Lines 118277 118292 +15
===========================================
+ Hits 67431 67478 +47
+ Misses 46963 46931 -32
Partials 3883 3883 ☔ View full report in Codecov by Sentry. |
2b50459
to
c8a7d63
Compare
It was unclear which testnet will replace the Mumbai testnet after the deprecation of the underlying Goerli testnet. Now we know the new L2 testnet on Polygon will be called `amoy` and will use the `80002` chain id. We can update our config accordingly. Read more: maticnetwork/heimdall#1096 maticnetwork/bor#1072
Succeeded by #1131 . Closing this PR. |
Description
This PR adds the network config/genesis for the new Amoy testnet to the repo. Using this, users will be able to start the node using chain="amoy" command.