Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add : amoy flags and genesis #1072

Closed
wants to merge 16 commits into from
Closed

add : amoy flags and genesis #1072

wants to merge 16 commits into from

Conversation

0xsharma
Copy link
Contributor

@0xsharma 0xsharma commented Nov 6, 2023

Description

This PR adds the network config/genesis for the new Amoy testnet to the repo. Using this, users will be able to start the node using chain="amoy" command.

Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments. Nothing affecting the main logic.

README.md Show resolved Hide resolved
cmd/geth/config.go Show resolved Hide resolved
cmd/geth/config.go Outdated Show resolved Hide resolved
internal/cli/server/chains/amoy.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (cf18ecc) 57.01% compared to head (914574b) 57.04%.
Report is 346 commits behind head on develop.

❗ Current head 914574b differs from pull request most recent head e8157bb. Consider uploading reports for the commit e8157bb to get more accurate results

Files Patch % Lines
core/genesis.go 0.00% 13 Missing ⚠️
params/bootnodes.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
+ Coverage    57.01%   57.04%   +0.03%     
===========================================
  Files          650      650              
  Lines       118277   118292      +15     
===========================================
+ Hits         67431    67478      +47     
+ Misses       46963    46931      -32     
  Partials      3883     3883              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michalinacienciala added a commit to keep-network/tbtc-v2 that referenced this pull request Nov 29, 2023
It was unclear which testnet will replace the Mumbai testnet after the
deprecation of the underlying Goerli testnet. Now we know the new L2 testnet on
Polygon will be called `amoy` and will use the `80002` chain id. We can update
our config accordingly.
Read more:
maticnetwork/heimdall#1096
maticnetwork/bor#1072
@0xsharma 0xsharma marked this pull request as ready for review January 3, 2024 12:56
@0xsharma 0xsharma changed the base branch from v1.1.0-beta-candidate to master January 4, 2024 08:55
@0xsharma 0xsharma changed the base branch from master to develop January 4, 2024 08:55
@0xsharma 0xsharma changed the base branch from develop to master January 4, 2024 09:41
@0xsharma 0xsharma changed the base branch from master to develop January 4, 2024 10:02
@0xsharma
Copy link
Contributor Author

Succeeded by #1131 . Closing this PR.

@0xsharma 0xsharma closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants