Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent #1124

Merged
merged 17 commits into from
Jan 19, 2024
Merged

Consistent #1124

merged 17 commits into from
Jan 19, 2024

Conversation

anshalshukla
Copy link
Contributor

@anshalshukla anshalshukla commented Jan 13, 2024 •
edited
Loading

Description

Includes changes to make HF naming consistent

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

bbaktaeho and others added 17 commits November 16, 2023 23:04
@bbaktaeho
fix GetTransactionReceiptsByBlock
7714cd8
@bbaktaeho
fix: lint
18c8802
@temaniarpit27
allow unprotected txns
91ff270
@anshalshukla
consensus/bor: handle blockalloc balance changes (#1074)
1065e21 
* fix: set balance in blockalloc

* chg: don't update balance if not zero

* fix: lint

* fix logic, add test cases
@temaniarpit27 @Raneet10
Update core/txpool/validation.go
9682679 
Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com>
@temaniarpit27
added log
4e3e1de
@temaniarpit27
Merge branch 'arpit/fix-shadowfork' of github.com:maticnetwork/bor in…
073d75c 
…to arpit/fix-shadowfork
@temaniarpit27
Merge pull request #1098 from maticnetwork/arpit/fix-shadowfork
abab36b 
allow unprotected txns
@marcello33
Update matic-cli in CI (#1103)
db5b398
@temaniarpit27
Merge pull request #1085 from bbaktaeho/fix/eth_api
2be2789 
internal/ethapi: fix GetTransactionReceiptsByBlock method
@pratikspatil024
test all default flags added via config file (#1105)
8b2f024
@VAIBHAVJINDAL3012
Removed the check for milestoneID in the GetVoteOnHash()
dac4c40
@bbaktaeho
internal/ethapi: fix signer in GetTransactionReceiptsByBlock method (#…
937dd6a 
…1107)

* fix: from address

* add: unit test for GetTransactionReceiptsByBlock
@marcello33
chg: bump some deps for sec vulsn (#1113)
01e1570
@VAIBHAVJINDAL3012
Merge pull request #1109 from maticnetwork/POS-2413
20f9295 
Removed the check for milestoneID in the GetVoteOnHash()
@anshalshukla @ulerdogan
EIP7212 / PIP27 (#1069)
f57c637 
add: EIP7217/PIP27 implementation and related test cases

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
@anshalshukla
chg: make HF consistent
b54c9b9
@anshalshukla anshalshukla changed the base branch from master to develop January 13, 2024 05:59
@anshalshukla anshalshukla requested a review from a team January 18, 2024 06:41
@temaniarpit27 temaniarpit27 changed the base branch from develop to v1.2.3-candidate January 19, 2024 11:36
@temaniarpit27 temaniarpit27 merged commit 603a425 into v1.2.3-candidate Jan 19, 2024
12 checks passed
@temaniarpit27 temaniarpit27 deleted the consistent branch January 19, 2024 11:37
@temaniarpit27 temaniarpit27 mentioned this pull request Jan 19, 2024
Merged
@temaniarpit27 temaniarpit27 restored the consistent branch January 19, 2024 11:50
@temaniarpit27 temaniarpit27 deleted the consistent branch January 19, 2024 11:51
@anshalshukla anshalshukla mentioned this pull request Mar 28, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anshalshukla @temaniarpit27 @Raneet10 @bbaktaeho @marcello33 @pratikspatil024 @VAIBHAVJINDAL3012