Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.go to allow the use of paths with the heimdall url #1126

Merged
merged 3 commits into from
Jan 15, 2024

Commits on Jan 13, 2024

  1. Update client.go to allow the use of paths with the heimdall url

    As reported to the polygon team 2 months ago in the Ankr polygon slack, the current code prevents the use of a path with the heimdall url, this was fixed in erigon erigontech/erigon@a3a6170 in response to my request by Mark Holt, and it seems this code was just copied from bor where it is incorrect too. This patch fixes that.
    PeaStew committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    55a4b7f View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Add reference to path library

    PeaStew committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    b3a5bcd View commit details
    Browse the repository at this point in the history
  2. Fix reversed order of values in unit tests and test removal of settin…

    …g u.path to rawPath (otherwise why do we need rawPath at all) seems like there were work arounds done here in bioth the unit tests AND the makeURL but logic needs to be examined
    PeaStew committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    7f9747a View commit details
    Browse the repository at this point in the history