Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arshad/cfds 637/dynamic leverage modal #391

Conversation

arshad-rao-deriv
Copy link

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

rupato-deriv and others added 30 commits July 11, 2023 14:33
* fix: for z-index of performance panel

* fix: for zindex
…inid (deriv-com#9017)

* fix: redirect user to correct withdrawal page using loginid

* fix: fixed a typo error

* chore: empty-commit

* chore: empty-commit

* chore: empty-commit

* chore: empty-commit

* chore: empty-commit

* chore: remove useStore usage from redirect.jsx

* chore: added test case for redirect.jsx

* chore: fixed condition for root redirection in redirect.jsx

* chore: empty-commit

* chore: added suggestions from PR comments

* fix: fixed bug for DIEL accounts as well

* chore: removed test file for redirect.spec.jsx

* chore: added suggested change from comments
…v-com#9204)

* fix: css for compare account af pk mg

* refactor: removed excess residence function and added dynamic css classes

---------

Co-authored-by: Hirad <hirad@regentmarkets.com>
Co-authored-by: Matin shafiei <matin@deriv.com>
* fix: previous-active-route

* fix: for mobile view

* fix: added NaN check

* fix: refactored code

* fix: removed numbers and addded tab names

---------

Co-authored-by: hirad-deriv <hirad@re-work.dev>
* fix: Make-the-tour-previous-and-next-button-bold

* fix: Make-the-tour-previous-and-next-button-bold

* fix: added loacalize

* fix: trigger

* fix: trigger test
…firmation (deriv-com#8957)

* feat(cashier): ✨ add `Confirmations` column to crypto transactions history

* refactor(cashier): ♻️ improve `CashierBreadcrumb`

* refactor(cashier): ♻️ improve `PageContainer`

* refactor(cashier): 🚚 move `SwitchToFiatAccountDialog` to components

* refactor(cashier): ♻️ clean-up cashier onboarding components

* feat(cashier): ✨ add `Confirmations` to recent transaction side note

* fix(cashier): ✅ fix failing test

* fix(cashier): ✅ fix failing test

* fix(cashier): 🐛 fix reaise issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 🐛 fix raised issues

* fix(cashier): 📝 resolve conflicts

* fix(cashier): 📝 resolve conflicts

* Merge branch 'master' into farzin/wall-852/show_pending_crypto_deposit_transaction_even_if_0_confirmation

---------

Co-authored-by: Farzin Mirzaie <farzin@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…another-file (deriv-com#9313)

* chore: update automation config

* chore: move is_release to loaders-config

* chore: change import statement
…ield (deriv-com#9001)

* fix: remove default max length from form input field in personal details form'

* chore: empty commit

---------

Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
* chore: removed widnow.open, added hack to open link

* chore: removed comment and refactored link

* chore: added comment

---------

Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
…v-com#8930)

Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
* fix: 🐛 removal of document image in POI

* fix: ♻️ modified params

* fix: ♻️ modified params

* feat: incorporated review comments

---------

Co-authored-by: hirad-deriv <hirad@re-work.dev>
…ient (deriv-com#9116)

* fix: p2p onboarding card is visible for unsupported client country

* chore: update test cases

* chore: create useIsHasP2PSupportedCurrencies hook

* chore: change logic, increase code coverage

* chore: hook renaming, change isp2penabled logic, refactor test cases

* refactor: revert cashier.tsx changes

* refactor: refactor repetitive lines in test file

* chore: revert useisp2penabled logics

* refactor: delete is_crypto check in p2p onboarding card

* refactor: refactor test file, delete unused import

* chore: empty commit

---------

Co-authored-by: hirad-deriv <hirad@re-work.dev>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
* fix: move redirection code to client store

* fix: move redirection code to client store

* fix: redirect_to_deriv_com_on+loggout

* fix: loggout

* chore: merge master

* chore: merge master

* fix: Trigger Build

* fix: trigger build

* fix: resolve conflicts

---------

Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
…9226)

* feat: ✨ remove Back to DerivGo redirection button

* feat: ✨ remove Back to DerivGo redirection button

* feat: added thr url for DerivGo

* fix: resolvong issue WALL-1288

---------

Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
…v-com#8298)

* feat: updating the dbot error message when low-risk client switching from non-eu to eu account

* chore: remove test case

* feat: add changes in implementation

* fix: types & fix variable should_show_eu_content from core - client store

* fix: removed button for eu logged out user

* fix: removed login without styles

* feat: added and refactored error implementation

* fix: removed unused import routes

* refactor: error-component from core package

* fix: is_low_risk wrong async execution

* fix: resolve conflicts after merge master in error-component test

* fix: loading delay of a few error messages, fix async issue for execution varaibles

* fix: flow of showing errors for diel, mf, cr accounts under eu/non-eu ip

* refactor: the code

* fix: circle ci issues

* fix: circle ci issues(2)

* chore: trigger versel

* refactor: method with useEffect

* fix: active_symbols retrieving

* fix: active_symbols retrieving(2)

* chore: debug check

* Revert "chore: debug check"

This reverts commit e56d3c7.

* fix: active_symbols retrieving(3)

* fix: active_symbols retrieving(4)

* chore: remove unused arguments

* refactor: active_symbols loading change

* fix: error message for EU only demo account

* fix: async initialization error

* refactor: method handleErrorForEu()

---------

Co-authored-by: Farabi Chowdhury <farabi@deriv.com>
* fix: gtm error on signup

* fix: check test link without catching failed promise

* chore: add localhost into gtm tag

* chore: add error logs for gtm

* chore: enabling gtm for staging and prod

---------

Co-authored-by: hirad-deriv <hirad@re-work.dev>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: added hash check

* fix: changed the check for checking pathname
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: styles of errors for specific clients

* chore: 🔥 fixed font size for error page

---------

Co-authored-by: maryia-matskevich-deriv <maryia.frantsava@binary.com>
Co-authored-by: Sandeep Singh <sandeepsingh@Sandeep-Singhs-Mac-CX9PCJX3L9.local>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
suisin-deriv and others added 25 commits July 21, 2023 17:07
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ.local>
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
…eriv-com#9333)

* feat: removed eslint dependencies and use eslint-config-deriv

* fix: removed localize plugin and updated deriv eslint plugin
…ue (deriv-com#9118)

* refactor: to resolve proxy track js issue

* Update packages/core/src/_common/base/socket_base.js

Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com>

---------

Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: sort button placement and padding alignment on dashboard

* fix: alignment of tables and texts in dashboard mobile

* fix: add padding on selected strategy
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: alignment issue on different languages

* fix: change word break from all to word

* fix: truncated text for recent bots list
)

* feat: added onfido check for high risk client

* feat: ⚡ Incorporated POA for Labuan when status is idv_photoid

* fix: failing testcase

* feat: reverted the change

* feat: added missing config

* feat: added POA

* feat: ✨ added POA trigger for IDV+photot status

* fix: ♻️ incorporated review comments

* chore: incorporated review comments

* feat: ✨ incorporated IDV revoked status

* refactor: ♻️ refactored code

* refactor: ♻️ incorporated review comments

* feat: ♻️ incorporated review comments

* feat: resolved issue with POA

* fix: 🐛 Trigger POA only in user is idv+photo verified for labuan

* fix: ✨ incorporated Resubmission triggers

* feat: incorporated testcases

* chore: trigger rebuild

* fix: resolved issue with POA trigger for idv+photo clients

* chore: 💚 trigger build

* fix: 🐛 resolved bugs regd high risk DBVI account

* Likhith/incorporate deriv hooks (deriv-com#42)

* feat: ✨ installed deriv-hooks

* feat: ✨ incorporated a new hook

* fix: ✅ added testcase

* feat: incorporated hook

* fix: 🎨 reverted changes of hooks implementation

* fix: ⚡ added testcases

---------

Co-authored-by: Matin shafiei <matin@deriv.com>
…verification (deriv-com#9035)

* chore: add issuing country to uploading file meta data

* chore: update binary-document-uploader package

* chore: add document issuing country in poa & poo document uploading

* chore: reverted the null check line change

* chore: add missing country_code upon retrying verification

* chore: issuing country is not required at the moment from poo & poa

* chore: empty commit

* chore: update import path to fix eslint error message

* ci: update package.json

* chore: revert files affected by formatting

---------

Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
…m#8907)

* chore: allow idv for vanuatu jurisdiction on MT5

* chore: update document status message in jurisdiction cards regarding idv

* refactor: shared util function to check idv supported resident

* refactor: util function to get supported verification service

* chore: added flag to check if idv is disallowed

* fix: failing test cases

* refactor: refactoring the condition for better readability and conciseness

* refactor: nullish coalescing operator

* refactor: updated type for authenticationStatusInfo util function

* chore: updated conditions regarding the vanuatu idv support in cfd

* chore: updated conditions regarding the vanuatu idv support in cfd

* chore: minor condition update

* chore: update poa condition to poi in card banner

* chore: resolve review comments

* chore: prevent idv for eu region selection

* refactor: condition to check verification status for maltainvest in cfd

* refactor: renamed status variable for better readability

* refactor: renamed status variable name

* chore: update jurisdiction content

* chore: update jurisdiction title indicator

* chore: update test case

* chore: update test case for format-response

* chore: update test case for cfd-poi

* chore: empty commit

* fix: 🐛 resolved incorrect section display (deriv-com#5)

* fix: failing test cases

---------

Co-authored-by: Shahzaib <shahzaib@deriv.com>
@coveralls
Copy link

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5677655488

  • 167 of 445 (37.53%) changed or added relevant lines in 99 files are covered.
  • 3784 unchanged lines in 39 files lost coverage.
  • Overall coverage increased (+0.06%) to 8.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/build/loaders-config.js 0 1 0.0%
packages/account/src/Components/poa/status/status-codes/status-codes.ts 0 1 0.0%
packages/account/src/Components/poi-poa-docs-submitted/poi-poa-docs-submitted.tsx 0 1 0.0%
packages/account/src/Components/poi/status/unsupported/unsupported.tsx 0 1 0.0%
packages/account/src/Sections/Verification/ProofOfAddress/proof-of-address-container.jsx 0 1 0.0%
packages/bot-web-ui/src/components/dashboard/dashboard-component/load-bot-preview/recent.tsx 0 1 0.0%
packages/bot-web-ui/src/components/dashboard/react-joyride-wrapper.tsx 0 1 0.0%
packages/bot-web-ui/src/stores/route-prompt-dialog-store.js 0 1 0.0%
packages/cashier/src/components/recent-transaction/recent-transaction.tsx 9 10 90.0%
packages/cashier/src/containers/routes/useUnsafeCashierRouteHandler.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/account/build/constants.js 1 0%
packages/account/src/Components/poi-poa-docs-submitted/poi-poa-docs-submitted.tsx 1 0%
packages/account/src/Components/poi/status/unsupported/unsupported.tsx 1 0%
packages/account/src/Sections/Verification/ProofOfIdentity/onfido-sdk-view-container.tsx 1 0%
packages/appstore/src/components/cfds-listing/index.tsx 1 0%
packages/cashier/src/constants/transaction-status.tsx 1 54.55%
packages/cfd/build/constants.js 1 0%
packages/cfd/src/Containers/cfd-dbvi-onboarding.tsx 1 0%
packages/cfd/src/Containers/cfd-password-modal.tsx 1 76.76%
packages/cfd/src/Containers/jurisdiction-modal/jurisdiction-modal-content-wrapper.tsx 1 32.65%
Totals Coverage Status
Change from base Build 5676000517: 0.06%
Covered Lines: 8702
Relevant Lines: 82062

💛 - Coveralls

@github-actions
Copy link

Generating Lighthouse report...

@matin-deriv matin-deriv merged commit f735fa4 into matin-deriv:dynamic_leverage Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.