Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps globals could be configurable? #16

Open
leontristain opened this issue Mar 9, 2019 · 1 comment · May be fixed by #17
Open

Perhaps globals could be configurable? #16

leontristain opened this issue Mar 9, 2019 · 1 comment · May be fixed by #17

Comments

@leontristain
Copy link

leontristain commented Mar 9, 2019

Hi Mator,

I am currently working on python bindings for xedit-lib. One thing I noticed is that xedit-lib hardcodes ProgramPath global to the location of ParamsStr(0) (see here). This value seems to get used when constructing the path to the Skyrim.Hardcoded.dat files. As a result, to make unit tests pass (where the invoked command looks like pytest -v ..., which runs in python), I have to copy the Skyrim.Hardcoded.dat file to my %localappdata%\Programs\Python\Python37 folder. I imagine a regular python app may have the same issue.

You mentioned earlier on discord that the Hardcoded.dat files are going away soon, so I think for the time being I can wait for that. It'll still be a while before I feel that this python wrapper, or any python-based application I make with it, would be ready for release, and I think for me this is a release blocker but doesn't hinder me from development or testing for the time being. (Any thoughts or guidance would be greatly appreciated)

Making this post mostly because I'm now wondering whether some of these values in general could be made more configurable... perhaps through an optional environment variable override? Or to expose a SetGlobal method? Hence this post.

Thanks,
leontristain

@leontristain
Copy link
Author

Hmm... it's also possible that pyinstaller or whatever people use to package python apps for end users on Windows could take care of this problem for me, but I won't know until I get to that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant