From ef5e8588ef91862ec4c69e695225ecece1c5c90c Mon Sep 17 00:00:00 2001
From: David Stansby <dstansby@gmail.com>
Date: Tue, 13 Jun 2023 13:56:49 +0100
Subject: [PATCH] Move data getting

---
 src/napari_matplotlib/features.py | 26 +++++++++++++++++++++++++-
 src/napari_matplotlib/scatter.py  | 27 ++-------------------------
 2 files changed, 27 insertions(+), 26 deletions(-)

diff --git a/src/napari_matplotlib/features.py b/src/napari_matplotlib/features.py
index 4b1c67b4..2845c21e 100644
--- a/src/napari_matplotlib/features.py
+++ b/src/napari_matplotlib/features.py
@@ -1,7 +1,10 @@
-from typing import Dict, List, Optional
+from typing import Any, Dict, List, Optional, Tuple
 
 import napari
 import napari.layers
+import numpy as np
+import numpy.typing as npt
+import pandas as pd
 from qtpy.QtWidgets import QComboBox, QLabel, QVBoxLayout
 
 from napari_matplotlib.base import NapariMPLWidget
@@ -86,6 +89,27 @@ def _ready_to_plot(self) -> bool:
             and all([self.get_key(dim) in valid_keys for dim in self.dims])
         )
 
+    def _get_data_names(
+        self,
+    ) -> Tuple[List[npt.NDArray[Any]], List[str]]:
+        """
+        Get the plot data from the ``features`` attribute of the first
+        selected layer.
+
+        Returns
+        -------
+        data : List[np.ndarray]
+            List contains X and Y columns from the FeatureTable. Returns
+            an empty array if nothing to plot.
+        names : List[str]
+            Names for each axis.
+        """
+        feature_table: pd.DataFrame = self.layers[0].features
+
+        names = [str(self.get_key(dim)) for dim in self.dims]
+        data = [np.array(feature_table[key]) for key in names]
+        return data, names
+
     def on_update_layers(self) -> None:
         """
         Called when the layer selection changes by ``self.update_layers()``.
diff --git a/src/napari_matplotlib/scatter.py b/src/napari_matplotlib/scatter.py
index 95721161..4fa45798 100644
--- a/src/napari_matplotlib/scatter.py
+++ b/src/napari_matplotlib/scatter.py
@@ -108,28 +108,5 @@ def draw(self) -> None:
             super().draw()
 
     def _get_data(self) -> Tuple[npt.NDArray[Any], npt.NDArray[Any], str, str]:
-        """
-        Get the plot data from the ``features`` attribute of the first
-        selected layer.
-
-        Returns
-        -------
-        data : List[np.ndarray]
-            List contains X and Y columns from the FeatureTable. Returns
-            an empty array if nothing to plot.
-        x_axis_name : str
-            The title to display on the x axis. Returns
-            an empty string if nothing to plot.
-        y_axis_name: str
-            The title to display on the y axis. Returns
-            an empty string if nothing to plot.
-        """
-        feature_table = self.layers[0].features
-
-        x = feature_table[self.get_key("x")]
-        y = feature_table[self.get_key("y")]
-
-        x_axis_name = str(self.get_key("x"))
-        y_axis_name = str(self.get_key("y"))
-
-        return x, y, x_axis_name, y_axis_name
+        data, names = self._get_data_names()
+        return data[0], data[1], names[0], names[1]