Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithRetryUntil request opt which can be used with any CSAPI call #417

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add WithRetryUntil request opt which can be used with any CSAPI call #417

merged 1 commit into from
Jul 21, 2022

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jul 21, 2022

This will repeat a request until the condition is satisfied.

Intended use: #415

@kegsay
Add WithRetryUntil request opt which can be used with any CSAPI call
371d153 
This will repeat a request until the condition is satisfied.

Intended use: #415
@kegsay kegsay added the enhancement New feature or request label Jul 21, 2022
@kegsay kegsay requested a review from reivilibre July 21, 2022 16:50
reivilibre
reivilibre approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks for polishing this idea up into something more idiomatic for Complement.

@kegsay kegsay merged commit 56dfc14 into main Jul 21, 2022
@kegsay kegsay deleted the kegan/retry-until branch July 21, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @reivilibre