Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add complement test for getting joined_members after leaving. #424

Merged
merged 7 commits into from
Aug 17, 2022
Merged

add complement test for getting joined_members after leaving. #424

merged 7 commits into from
Aug 17, 2022

Conversation

andrewdoh
Copy link
Contributor

Signed-off-by: Andrew Doh andrewddo@gmail.com

@andrewdoh
add complement test for getting joined_members after leaving.
390ef4e 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh andrewdoh mentioned this pull request Jul 24, 2022
Closed
@andrewdoh
change response match to be consistent with synapse error message.
cc8a06e 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@DMRobertson DMRobertson requested review from a team July 25, 2022 09:29
DMRobertson
DMRobertson suggested changes Jul 25, 2022
View reviewed changes
tests/csapi/apidoc_room_state_test.go Outdated Show resolved Hide resolved
tests/csapi/apidoc_room_state_test.go Outdated Show resolved Hide resolved
andrewdoh and others added 2 commits July 25, 2022 10:10
@andrewdoh @DMRobertson
Update tests/csapi/apidoc_room_state_test.go
511286e 
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
@andrewdoh
relax test check, due to localization and not being a part of th spec.
2e336ff 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh andrewdoh requested a review from DMRobertson July 25, 2022 17:23
DMRobertson
DMRobertson approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DMRobertson
Copy link
Contributor

Will probably need matrix-org/synapse#13374 before merging.

@babolivier
Copy link
Contributor

babolivier commented Aug 3, 2022 •
edited
Loading

It looks like this PR is having issue with the CI:

tests/csapi/apidoc_room_state_test.go:16:2: http redeclared as imported package name
	/home/runner/work/complement/complement/tests/csapi/apidoc_room_state_test.go:4:2: previous declaration

This seems to be because #415 added an import of net/http to this file. @andrewdoh can you fix this please? Happy to merge this PR once it's done (and CI is happy)

@andrewdoh
remove duplicate import.
91d0493 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
Copy link
Contributor Author

andrewdoh commented Aug 3, 2022 •
edited
Loading

It looks like this PR is having issue with the CI:

tests/csapi/apidoc_room_state_test.go:16:2: http redeclared as imported package name
	/home/runner/work/complement/complement/tests/csapi/apidoc_room_state_test.go:4:2: previous declaration

This seems to be because #415 added an import of net/http to this file. @andrewdoh can you fix this please? Happy to merge this PR once it's done (and CI is happy)

yes, its fixed. you're right, looks like we both imported http per #415. thanks.

@andrewdoh
Copy link
Contributor Author

andrewdoh commented Aug 4, 2022 •
edited
Loading

hmmm, I suppose this new error means that its not working for golang implementation of the matrix protocol? I could add it tomorrow if that's right. @babolivier

@kegsay
Copy link
Member

kegsay commented Aug 11, 2022

You are correct, please runtime.SkipIf(runtime.Dendrite)

@andrewdoh
skip test for dendrite.
02ad6eb 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
Copy link
Contributor Author

I've updated the PR with the suggested, thanks @kegsay.

@andrewdoh andrewdoh requested a review from DMRobertson August 15, 2022 04:04
@DMRobertson DMRobertson merged commit 9b3628f into matrix-org:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewdoh @DMRobertson @babolivier @kegsay