docker: don't push on a Pull Request #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the github action triggers on a PR too, `github.ref` will be the target branch for merging (typically `develop`). In that case, don't try to login/push to docker hub. https://docs.github.com/en/actions/learn-github-actions/contexts#github-context Signed-off-by: Дамјан Георгиевски <gdamjan@gmail.com>
|
Looks good, happy to merge. |
Half-Shot
approved these changes
Aug 7, 2023
Half-Shot
reviewed
Aug 7, 2023
| @@ -11,7 +11,8 @@ env: | |||
| DOCKER_NAMESPACE: matrixdotorg | |||
| PLATFORMS: linux/amd64 | |||
| # Only push if this is develop, otherwise we just want to build | |||
| PUSH: ${{ github.ref == 'refs/heads/develop' }} | |||
| # On a PR github.ref is the target branch, so don't push for that either | |||
| PUSH: ${{ github.ref == 'refs/heads/develop' && github.event_name != 'pull_request' }} | |||
There was a problem hiding this comment.
Hm, the jobs might need a env.PUSH == 'true' perhaps?
There was a problem hiding this comment.
ah, indeed, since PUSH is an env var.
Signed-off-by: Дамјан Георгиевски <gdamjan@gmail.com>
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the github action triggers on a PR too,
github.refwill be the target branch for merging (typicallydevelop). In that case, don't try to login/push to docker hub.https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Signed-off-by: Damjan Georgievski gdamjan@gmail.com