Stop XMPP users (and matrix users) from appearing anonymous over the gateway #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we start emitting the jid of XMPP users over the gateway to other XMPP users and matrix users. This also means we no longer use the anonymous JID when calculating user_ids for the rooms, which means that XMPP users coming over the bridge will no longer have ugly looking user_ids (or well, ish).
The downside is that this means other users now know who you are, but this is presently how matrix operates and so it feels sane to build the gateway the same way. In addition, we also notify XMPP users that the room is both logged and non-anonymous so they won't be surprised to know matrix users can read the history forever etc.