Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove score from /reportEvent #522

Open
Half-Shot opened this issue Aug 8, 2019 · 2 comments
Open

Remove score from /reportEvent #522

Half-Shot opened this issue Aug 8, 2019 · 2 comments
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@Half-Shot
Copy link
Contributor

Context: https://matrix.org/docs/spec/client_server/r0.5.0#post-matrix-client-r0-rooms-roomid-report-eventid

This is quite a useless key, as I don't think it was well thought through as to how you would define offensiveness as an integer. If it's taken straight from the user, they are very likely to use the maximum value as it would probably be interpreted as an urgent-ness meter.

Even if hidden behind some checkboxes, how do you define what is more offensive for individuals.

At the very minimum this should be an optional key, but ideally should be thrown straight out as currently all supported matrix clients hardcode a value.

https://github.com/matrix-org/matrix-react-sdk/pull/3290/files#diff-551ca16d6a8ffb96888b337b5246402dR66

@turt2live turt2live added A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol labels Aug 8, 2019
@aaronraimist
Copy link
Contributor

Also why is the reason required but "may be blank"? Might as well just be optional.

@turt2live
Copy link
Member

probably from a legacy way of doing things. Certainly should be optional these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Development

No branches or pull requests

3 participants