-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add m.login.appservice to the spec #3324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've put all this in the wrong section. MSC2778 doesn't specify a UIA authentication type, but rather a modification to the /login
endpoint (which doesn't use UIA). It should be in this section: https://spec.matrix.org/unstable/client-server-api/#login.
Sorry, my mistake. I homed in on the thing that looked like login types without thinking. I've moved and reworked the section to hopefully make it fit better with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks better now. A few nits.
Would it be helpful to add a link from the appservice spec?
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Half-Shot do you have bandwidth to update this? |
My bandwidth is in the negatives atm |
Would you be opposed to this being taken over to get it over the line? |
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm - thanks!
Co-authored-by: Travis Ralston <travisr@matrix.org>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Hubert Chathi <hubertc@matrix.org> Co-authored-by: Travis Ralston <travisr@matrix.org>
* move login API definitions to the right heading regressed from matrix-org/matrix-spec-proposals#3324 * Create 1382.clarification
* move login API definitions to the right heading regressed from matrix-org/matrix-spec-proposals#3324 * Create 1382.clarification
#2778