Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m.room.redaction has redacts at the event level (SPEC-164) #69

Closed
matrixbot opened this issue May 21, 2015 · 2 comments · Fixed by matrix-org/matrix-spec-proposals#2174
Closed

m.room.redaction has redacts at the event level (SPEC-164) #69

matrixbot opened this issue May 21, 2015 · 2 comments · Fixed by matrix-org/matrix-spec-proposals#2174
Labels
p2 wart A point where the protocol is inconsistent or inelegant

Comments

@matrixbot
Copy link
Member

matrixbot commented May 21, 2015 •
edited by richvdh
Loading

Submitted by @​kegan:matrix.org
m.room.redaction has the redacts key at the top level of the event. Is this really necessary? Given nearly every other event doesn't do this, it would be great to move it to content.redacts instead.

(Imported from https://matrix.org/jira/browse/SPEC-164)
@matrixbot matrixbot added the p2 label Oct 28, 2016
@matrixbot matrixbot changed the title v2 redact event layout v2 redact event layout (SPEC-164) Oct 31, 2016
@matrixbot matrixbot added the spec-bug Something which is in the spec, but is wrong label Nov 7, 2016
@matrixbot matrixbot changed the title v2 redact event layout (SPEC-164) redact event layout (SPEC-164) Nov 7, 2016
@matrixbot matrixbot added enhancement A suggestion for a relatively simple improvement to the protocol and removed spec-bug Something which is in the spec, but is wrong labels Nov 7, 2016
@turt2live turt2live added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label Feb 7, 2019
@richvdh richvdh mentioned this issue Jul 13, 2019
Closed
@richvdh richvdh changed the title redact event layout (SPEC-164) m.room.redaction has redacts at the event level (SPEC-164) Jul 13, 2019
@richvdh richvdh added wart A point where the protocol is inconsistent or inelegant and removed clarification An area where the expected behaviour is understood, but the spec could do with being more explicit enhancement A suggestion for a relatively simple improvement to the protocol labels Jul 13, 2019
@richvdh richvdh mentioned this issue Jul 14, 2019
Merged
@richvdh
Copy link
Member

richvdh commented Aug 22, 2019

I think I want this to stay open until we've actually delivered a room version that fixes it

@richvdh richvdh reopened this Aug 22, 2019
@joepie91 joepie91 mentioned this issue Jul 11, 2020
Closed
@ghost ghost mentioned this issue Aug 16, 2021
Closed
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@jplatte
Copy link
Contributor

jplatte commented Oct 24, 2023

Room v11 was shipped with redacts in content!

@richvdh richvdh closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2 wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC2174: Move the redacts key to a sane place matrix-org/matrix-spec-proposals
4 participants
@jplatte @turt2live @richvdh @matrixbot