Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Summaries (was: Calculate room names server-side) #688

Closed
matrixbot opened this issue Jul 12, 2016 · 12 comments
Closed

Room Summaries (was: Calculate room names server-side) #688

matrixbot opened this issue Jul 12, 2016 · 12 comments
Assignees
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Comments

@matrixbot
Copy link
Member

matrixbot commented Jul 12, 2016

Documentation: https://docs.google.com/document/d/11i14UI1cUz-OJ0knD5BFu7fmT6Fo327zvMYqfSAR7xs/edit#
Author: @ara4n
Date: 2018-06-10

The rules for calculating the display name of a room are complicated. It would be preferable to offload some of this work to the server.

This becomes even more important with the advent of lazy-loaded members (#1227), as a given client will typically not have enough info to correctly name the room otherwise.

This would probably mean adding a field to the /sync response.

Care would need to be taken to make sure that the textual parts of the name can be translated into the user's preferred language. This would probably mean providing the information in a structured manner (possibly as well as supplying preformatted strings in one or more languages for clients to use for simplicity if they prefer).

(Imported from https://matrix.org/jira/browse/SPEC-425)

(Reported by @richvdh)

@matrixbot
Copy link
Member Author

Jira watchers: @richvdh

@matrixbot
Copy link
Member Author

matrixbot commented Jul 12, 2016

Links exported from Jira:

relates to https://github.com/matrix-org/matrix-doc/issues/573
relates to SYN-265

@ara4n
Copy link
Member

ara4n commented Jun 10, 2018

This comes up as a blocker for lazyloading members (#1227), where otherwise we don't have enough data to calculate the name locally. Going to write a proposal for how to fix this (which I vaguely remember sketching out already somewhere, but i don't think has ever been actually written down).

@ara4n ara4n added proposal-wip proposal A matrix spec change proposal and removed improvement A suggestion for a relatively simple improvement to the protocol p4 labels Jun 10, 2018
@ara4n ara4n changed the title Calculate room names server-side (SPEC-425) Calculate room names server-side Jun 10, 2018
@ara4n ara4n changed the title Calculate room names server-side Room Summaries (was: Calculate room names server-side) Jul 24, 2018
@KitsuneRal
Copy link
Member

Since room versioning MSC is apparently overtaking this one in the race to being specced - can we please include the room version in the summary so that clients wouldn't need to explicitly request m.room.create just to figure if they can even read the contents of that room?

@richvdh
Copy link
Member

richvdh commented Aug 16, 2018

@KitsuneRal: let's take room versions back to #1425.

@richvdh
Copy link
Member

richvdh commented Aug 16, 2018

This has been implemented in matrix-org/synapse#3574, so I'd suggest that anyone with objections makes them quickly.

@turt2live
Copy link
Member

turt2live commented Aug 20, 2018

I vote that this MSC should enter the final comment period with the view of having it be a spec PR next week. Can the Spec Core Team either approve going into FCP or comment with any concerns. Those outside the team with concerns/suggestions are also welcome to raise them.

(also this has been in review for a while now, but no one updated the labels)

@ara4n
Copy link
Member

ara4n commented Aug 20, 2018

Having been playing with it over the last few days on riot/web, it seems to be working well in practice. So 👍 from me.

@uhoreg
Copy link
Member

uhoreg commented Aug 21, 2018

Added a little question to the doc, and I'm a bit confused about the calculation of the room name (as with Manu's comment) but I'm not seeing anything fundamental that should stop it from going to FCP.

@turt2live turt2live added the client-server Client-Server API label Sep 5, 2018
@richvdh
Copy link
Member

richvdh commented Nov 6, 2018

In the same vein as #1227 (comment), I think we should declare that this had a de-facto FCP, and now needs speccing.

@turt2live
Copy link
Member

Spec PR: #2035

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 28, 2019
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 11, 2019
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 21, 2020
deepbluev7 added a commit to deepbluev7/matrix-doc that referenced this issue Jul 12, 2021
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Development

No branches or pull requests

7 participants