MXCrypto: Use the last olm session that got a message #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion objects from OLMKit
With the add MXOlmSession.lastReceivedMessageTs element-hq/element-ios#2128
| MXRealmOlmSession *realmOlmSession = [MXRealmOlmSession objectsInRealm:self.realm | ||
| where:@"sessionId = %@ AND deviceKey = %@", sessionId, deviceKey].firstObject; | ||
|
|
||
| OLMSession *olmSession = [NSKeyedUnarchiver unarchiveObjectWithData:realmOlmSession.olmSessionData]; |
There was a problem hiding this comment.
- [NSKeyedUnarchiver unarchiveObjectWithData] take a non null argument. Verify realmOlmSession nullability before.
Fix Steve's comment
SBiOSoftWhare
approved these changes
Dec 20, 2018
bmarty
reviewed
Dec 28, 2018
| device. | ||
|
|
||
| @param deviceKey the public key of the other device. | ||
| @return {object} A map from sessionId to Base64 end-to-end session. | ||
| @return a array of end-to-end sessions sorted by the last updated first. |
| device sorted by `lastReceivedMessageTs`, the most recent(higest value) first. | ||
|
|
||
| @param deviceKey the public key of the other device. | ||
| @return a array of end-to-end sessions. |
|
|
||
| /** | ||
| Retrieve all end-to-end sessions between the logged-in user and another | ||
| device sorted by `lastReceivedMessageTs`, the most recent(higest value) first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes element-hq/element-ios#2128.