Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parser #1425

Closed
resynth1943 opened this issue Jul 28, 2020 · 3 comments
Closed

Markdown parser #1425

resynth1943 opened this issue Jul 28, 2020 · 3 comments

Comments

@resynth1943
Copy link

I love Matrix and Element. I'm an avid user of both products.

Nevertheless, let's cut right down to the chase: the Markdown parser you seem to be using currently (commonmark) is incapable of rendering ~~ to a strike-through.

After Discord implemented this, I think it's an expected feature. I have done some research, and markdown-it does support strike-through (and seems to have a better ecosystem).

Would you be open to switching to another Markdown parser?

commonmark/commonmark.js#120, an issue filed in 2017, asks for strike-through support. The maintainers seem to be oblivious to it. Perhaps this is the sign of poor maintenance / community?

Anyway, I'd love to have a discussion. If not markdown-it, perhaps something else?

Thanks,
Resynth

@t3chguy
Copy link
Member

t3chguy commented Jul 28, 2020

matrix-js-sdk doesn't do any Markdown parsing whatsoever. Perhaps you want https://github.com/vector-im/riot-web/issues/5940

@t3chguy t3chguy closed this as completed Jul 28, 2020
@resynth1943
Copy link
Author

matrix-js-sdk doesn't do any Markdown parsing whatsoever. Perhaps you want vector-im/riot-web#5940

Wait, what? I found the Markdown parser here. I even grep'd the source code.

@t3chguy
Copy link
Member

t3chguy commented Jul 28, 2020

Its in matrix-react-sdk, not matrix-js-sdk: https://github.com/matrix-org/matrix-react-sdk/blob/96ba645cbd8774148f86e049222268cebd3638e2/package.json#L62

image

Not sure what you grep'd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants