Update PR guidelines for easier review #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Sep 17, 2021
Comment on lines
+27
to
+28
| * Include both **before** and **after** screenshots to easily compare and discuss | ||
| what's changing. |
There was a problem hiding this comment.
screenshots probably aren't needed at this level
There was a problem hiding this comment.
This contributing guide linked from the matrix-react-sdk project where it would be highly useful, https://github.com/matrix-org/matrix-react-sdk#developer-guide
There was a problem hiding this comment.
One day we should stop inheriting our docs from other projects, but today is not that day...
turt2live
approved these changes
Sep 17, 2021
|
Thanks for reviewing this @turt2live! Meta 🦾 |
MadLittleMods
added a commit
that referenced
this pull request
Jun 2, 2022
…tributing Follow-up to #1933 Spawning from various recent documents and comments: - https://github.com/vector-im/element-meta/wiki/Review-process - matrix-org/synapse#12846 (comment) - https://gitlab.matrix.org/new-vector/internal/-/wikis/Backend/Reviews
MadLittleMods
added a commit
that referenced
this pull request
Jun 7, 2022
… contributing (#2432) Follow-up to #1933 Spawning from various recent documents and comments: - https://github.com/vector-im/element-meta/wiki/Review-process - matrix-org/synapse#12846 (comment) - https://gitlab.matrix.org/new-vector/internal/-/wikis/Backend/Reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PR guidelines for easier review.
This is spawning from me going over the
matrix-react-sdkPR backlog and trying to get things less design-blocked.This change is marked as an internal change (Task), so will not be included in the changelog.