Modernize http-api - move from browser-request to fetch
#2719
+2,530
−2,545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
force-pushed
the
t3chguy/fetch
branch
2 times, most recently
from
689d072
to
c0c1c0a
Compare
t3chguy
force-pushed
the
t3chguy/fetch
branch
12 times, most recently
from
bb4be96
to
f6f4a0a
Compare
…chguy/fetch � Conflicts: � yarn.lock
…chguy/fetch � Conflicts: � src/client.ts � src/crypto/EncryptionSetup.ts
3 tasks
turt2live
reviewed
Oct 7, 2022
turt2live
approved these changes
Oct 11, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Oct 29, 2022
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801. * Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680. * Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760. * Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk. * Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)). * Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)). * Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)). * Add custom notification handling for MSC3401 call events ([\matrix-org#2720](matrix-org#2720)). * Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)). * Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)). * Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839. * Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206. * Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505. * Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)). * Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)). * Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke. * Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435. * Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
clarkf
added a commit
to clarkf/matrix-js-sdk
that referenced
this pull request
Jan 5, 2023
'qs' appears to be unused since 34c5598 (PR matrix-org#2719).
clarkf
added a commit
to clarkf/matrix-js-sdk
that referenced
this pull request
Jan 5, 2023
'qs' appears to be unused since 34c5598 (PR matrix-org#2719). Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
clarkf
added a commit
to clarkf/matrix-js-sdk
that referenced
this pull request
Jan 6, 2023
'qs' appears to be unused since 34c5598 (PR matrix-org#2719). Signed-off-by: Clark Fischer <clark.fischer@gmail.com>
turt2live
pushed a commit
that referenced
this pull request
Jan 6, 2023
fnwbr
added a commit
to medienhaus/medienhaus-spaces
that referenced
this pull request
May 4, 2023
"authedRequest" was changed in v21.0.0: https://github.com/matrix-org/matrix-js-sdk/releases/tag/v21.0.0 / matrix-org/matrix-js-sdk#2719
|
i'm facing an issue with |
fnwbr
added a commit
to fnwbr/Matrix-CRDT
that referenced
this pull request
Mar 5, 2024
With matrix-org/matrix-js-sdk#2719 the signature of `authedRequest` has changed. They now do not expect a callback as the first parameter anymore. All other parameters have just moved up by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2415
Fixes #801
Notes: Changes the
uploadContentAPI, kills offrequestandbrowser-requestin favour offetch, removed callback support on a lot of the methods, adds a lot of tests.Here's what your changelog entry will look like:
🚨 BREAKING CHANGES
uploadContentAPI, kills offrequestandbrowser-requestin favour offetch, removed callback support on a lot of the methods, adds a lot of tests. (#2719). Fixes TypeError: this.opts.request is not a function when running client in Node.js; reopen issue #1191 #2415 and Consider switching http libs #801.