-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra insurance that we don't mix events in the wrong timelines - v2 #2856
Merged
MadLittleMods
merged 10 commits into
develop
from
madlittlemods/no-addEventToTimeline-mixing
Nov 7, 2022
Merged
Extra insurance that we don't mix events in the wrong timelines - v2 #2856
MadLittleMods
merged 10 commits into
develop
from
madlittlemods/no-addEventToTimeline-mixing
Nov 7, 2022
Commits on Nov 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0f0e8f9 - Browse repository at this point
Copy the full SHA 0f0e8f9View commit details -
Fix null client error in tests even though it should not be null acco…
…rding to the signature
Configuration menu - View commit details
-
Copy full SHA for 58ed2f3 - Browse repository at this point
Copy the full SHA 58ed2f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b91b03b - Browse repository at this point
Copy the full SHA b91b03bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd36a4 - Browse repository at this point
Copy the full SHA 7fd36a4View commit details -
Only run canContain for room timelines
Fix test failure in `sliding-sync/sliding-sync.ts` -> `"should show the right unread notifications"` ``` Cannot call `EventTimelineSet::canContain without a `room` set. Set the room when creating the EventTimelineSet to call this method. at EventTimelineSet.canContain (VM4503 200:726:13) at EventTimelineSet.addEventToTimeline (VM4503 200:576:15) at EventTimelineSet.addLiveEvent (VM4503 200:527:10) at eval (VM4587 281:722:145) at Array.forEach (<anonymous>) at SlidingSyncSdk.purgeNotifications (VM4587 281:720:22) at SlidingSyncSdk.onLifecycle (VM4587 281:263:14) at SlidingSync.emit (VM4407 21:153:5) at SlidingSync.emit (VM4472 169:45:18) at SlidingSync.invokeLifecycleListeners (VM4588 282:378:10) ```
Configuration menu - View commit details
-
Copy full SHA for 52d4280 - Browse repository at this point
Copy the full SHA 52d4280View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1449f9 - Browse repository at this point
Copy the full SHA a1449f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3109e28 - Browse repository at this point
Copy the full SHA 3109e28View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f37e6 - Browse repository at this point
Copy the full SHA f2f37e6View commit details
Commits on Nov 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ded1433 - Browse repository at this point
Copy the full SHA ded1433View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b6f4f - Browse repository at this point
Copy the full SHA e3b6f4fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.