Support MSC4140: Delayed events (Futures) #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
toger5
reviewed
Jul 4, 2024
4 tasks
4 tasks
toger5
reviewed
Jul 11, 2024
t3chguy
reviewed
Jul 11, 2024
t3chguy
reviewed
Jul 11, 2024
t3chguy
reviewed
Jul 11, 2024
t3chguy
reviewed
Jul 11, 2024
toger5
approved these changes
Jul 12, 2024
|
I finally got the code coverage of MatrixRTCSession.ts that I was after, so barring further review, I'm done with pushing more commits here. |
t3chguy
approved these changes
Jul 18, 2024
toger5
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
This looks very good thanks.
I think, i cannot follow why delayed events are entangled with threads (is it just because of the method overloading?
Reading through this code again I am very surpriced that this does not use a props interface param for the function paramters
myOverloadedFunction(props: {delay?: number, threadId?: string, eventType: EventType ...})
|
Since this PR is already reviewed, I'll squash & rebase its commits before merging, because
|
and use them for more reliable MatrixRTC session membership events. Also implement "parent" delayed events, which were in a previous version of the MSC and may be reintroduced or be part of a new MSC later. NOTE: Still missing is support for sending encrypted delayed events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist
public/exportedsymbols have accurate TSDoc documentation.