Support Futures via widgets #4311
Conversation
AndrewFerr
requested review from
t3chguy and
robintown
and removed request for
a team
|
Putting this back into draft until the widget API is up-to-speed with the recent revisions to MSC4140. |
AndrewFerr
force-pushed
the
af/msc4157
branch
2 times, most recently
from
43327d1 to
cddac44
Compare
|
I'll take this out of draft once the dependent widget-api PR is merged. |
Not quite -- it would be nice if the widget-api's release workflow could be fixed before cutting a new release for it, which this PR will depend on. |
|
After the rebasing, the effective changes since the last review start from 3c65057. |
| if (!(await this.doesServerSupportUnstableFeature(UNSTABLE_MSC4140_DELAYED_EVENTS))) { | ||
| throw Error("Server does not support the delayed events API"); | ||
| } |
There was a problem hiding this comment.
It feels a little surprising that the host client might approve the capability without having server support. (I would expect this check to be the host's responsibility, ideally)
| @@ -268,7 +268,8 @@ describe("MSC4108SignInWithQR", () => { | |||
| it("should abort if device doesn't come up by timeout", async () => { | |||
| jest.spyOn(global, "setTimeout").mockImplementation((fn) => { | |||
| (<Function>fn)(); | |||
| return -1; | |||
| // TODO: mock timers properly | |||
| return -1 as any; | |||
There was a problem hiding this comment.
Why are these needed now but weren't before?
There was a problem hiding this comment.
I'm not actually sure...it must be due to a dependency update. Typechecks expect the return value to be a NodeJS Timeout instead of a timeout ID.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Dependencies:
Checklist
public/exportedsymbols have accurate TSDoc documentation.