Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move features of MatrixHttpApi related to application-services into subclass #204

Open
1 task
non-Jedi opened this issue May 14, 2018 · 0 comments
Open
1 task

Comments

@non-Jedi
Copy link
Collaborator

non-Jedi commented May 14, 2018

See discussion on #143.

In general, I want to move the sdk more towards a set of composable classes with a clear api for extending them. Something where parameters specific to application-service usage live either in an additional kwarg extras or in slurped kwargs **extras seems like the right direction for this.

Issues to be resolved still:

  • What if somebody wants to combine functionality available on two different subclasses of MatrixHttpApi (e.g. application-service support and async as in Add an asyncio version of the HttpApi class #168)? We should support composing those together somehow.

Maybe in addition to swapping out _send we should have a list of decorators that get applied to _send?

cc @Cadair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant